Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AnomaSet and AnomaSet{to, from}List #3296

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Add support for AnomaSet and AnomaSet{to, from}List #3296

merged 6 commits into from
Jan 29, 2025

Conversation

paulcadman
Copy link
Collaborator

@paulcadman paulcadman commented Jan 28, 2025 •
edited
Loading

This PR adds support for the AnomaSet type and related builtins:

builtin anoma-set
axiom AnomaSet : Type -> Type;

builtin anoma-set-to-list
axiom anomaSetToList {A} (set : AnomaSet A) : List A;

builtin anoma-set-from-list
axiom anomaSetFromList {A} (list : List A) : AnomaSet A;

These builtins require an Anoma node ref update, specifically 5c7bd8121206fbebdc3f7f75fdea3697f09566a0 because of a bug in Anoma node related to handling of Nock list -> Elixir list transformations. see:

@paulcadman paulcadman self-assigned this Jan 28, 2025
@paulcadman
Add test for AnomaSet{toList, fromList}
e65d3ea
@paulcadman
Update Anoma node ref
1dff2ea 
This ref contains updates to calling jets and a bug fix in the
translation of Nock nouns to Elixir lists.
@paulcadman
Add validation for AnomaSet builtins
4c9e480
@paulcadman
Add missing test file
c3e8a5f
@paulcadman paulcadman added this to the 0.6.10 milestone Jan 29, 2025
@paulcadman paulcadman marked this pull request as ready for review January 29, 2025 12:28
@janmasrovira janmasrovira merged commit 7d1c6a4 into main Jan 29, 2025
7 of 8 checks passed
@janmasrovira janmasrovira deleted the anoma-set branch January 29, 2025 17:13
@janmasrovira janmasrovira mentioned this pull request Jan 29, 2025
Merged
janmasrovira added a commit that referenced this pull request Jan 30, 2025
@janmasrovira
Pre-register all type axioms in internal to core (#3297)
4ed8eae 
- This pr fixes a bug that was not exposed before
#3296. We were only pre-registering
axioms with type `Type`. Now we pre-register all axioms that define a
builtin type as well as those which have a type generated from `Type`
and `->`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira janmasrovira approved these changes

@lukaszcz lukaszcz Awaiting requested review from lukaszcz

Assignees

@paulcadman paulcadman

Labels
anoma
Projects
None yet
Milestone
0.6.10
Development

Successfully merging this pull request may close these issues.
2 participants
@paulcadman @janmasrovira