Fix pre-commit errors and rename test case

expr/interval_compound_literal.go

@@ -2,6 +2,7 @@ package expr
 
 import (
 	"errors"
+
 	"github.com/substrait-io/substrait-go/proto"
 	"github.com/substrait-io/substrait-go/types"
 )
@@ -49,6 +50,7 @@ func WithIntervalCompoundSubSeconds(subSeconds int64) func(*intervalDateParts) {
 // NewIntervalLiteralUptoSubSecondPrecision creates an interval literal which allows upto subsecond precision
 // arguments: precision and nullable property (n)
 // datePartsOptions is options to set value parts (month, year, day, seconds, subseconds).
+// datePartsOptions can be set using WithIntervalCompound(Years|Months|Days|Seconds|SubSeconds) functions
 // If multiple options of same types (e.g. multiple second options) are provided only value of last part is considered
 func NewIntervalLiteralUptoSubSecondPrecision(precision types.TimePrecision, n types.Nullability, datePartsOptions ...intervalDatePartsOptions) Literal {
 	intervalCompoundType := types.NewIntervalCompoundType(precision).WithNullability(n)
@@ -77,10 +79,6 @@ func intervalPartsValToProto(idp *intervalDateParts, ict *types.IntervalCompound
 		}
 		intrCompPB.IntervalYearToMonth = yearToMonthProto
 	}
-	if idp.days == 0 && idp.seconds == 0 && idp.subSeconds == 0 {
-		// all parts are >= month granularity so no need to set daytosecond component
-		return intrCompPB
-	}
 
 	dayToSecondProto := &proto.Expression_Literal_IntervalDayToSecond{
 		Days:          idp.days,

expr/interval_compound_literal_test.go

@@ -1,12 +1,13 @@
 package expr
 
 import (
+	"testing"
+
 	"github.com/google/go-cmp/cmp"
 	"github.com/stretchr/testify/assert"
 	"github.com/substrait-io/substrait-go/proto"
 	"github.com/substrait-io/substrait-go/types"
 	"google.golang.org/protobuf/testing/protocmp"
-	"testing"
 )
 
 const (
@@ -17,7 +18,7 @@ const (
 	subSecondsVal int64 = 10000
 )
 
-func TestIntervalCompoundProtoExpressionLiteral(t *testing.T) {
+func TestIntervalCompoundToProto(t *testing.T) {
 	// precision and nullability belong to type. In type unit tests they are already tested
 	// for different values so no need to test for multiple values
 	precisonVal := types.PrecisionNanoSeconds
@@ -39,6 +40,7 @@ func TestIntervalCompoundProtoExpressionLiteral(t *testing.T) {
 			[]intervalDatePartsOptions{yearOption, monthOption},
 			&proto.Expression_Literal_IntervalCompound_{IntervalCompound: &proto.Expression_Literal_IntervalCompound{
 				IntervalYearToMonth: &proto.Expression_Literal_IntervalYearToMonth{Years: yearVal, Months: monthVal},
+				IntervalDayToSecond: &proto.Expression_Literal_IntervalDayToSecond{PrecisionMode: nanoSecPrecision},
 			}},
 		},
 		{"WithOnlyDayToSecond",
@@ -67,8 +69,7 @@ func TestIntervalCompoundProtoExpressionLiteral(t *testing.T) {
 	} {
 		t.Run(tc.name, func(t *testing.T) {
 			expectedProtoExpression := &proto.Expression_Literal{LiteralType: tc.expectedExpressionLiteral, Nullable: nullable}
-			var intervalCompoundLiteral Literal
-			intervalCompoundLiteral = NewIntervalLiteralUptoSubSecondPrecision(precisonVal, nullability, tc.options...)
+			intervalCompoundLiteral := NewIntervalLiteralUptoSubSecondPrecision(precisonVal, nullability, tc.options...)
 			if diff := cmp.Diff(intervalCompoundLiteral.ToProtoLiteral(), expectedProtoExpression, protocmp.Transform()); diff != "" {
 				t.Errorf("proto didn't match, diff:\n%v", diff)
 			}

expr/interval_year_to_month_test.go

@@ -1,12 +1,13 @@
 package expr
 
 import (
+	"testing"
+
 	"github.com/google/go-cmp/cmp"
 	"github.com/stretchr/testify/assert"
 	"github.com/substrait-io/substrait-go/proto"
 	"github.com/substrait-io/substrait-go/types"
 	"google.golang.org/protobuf/testing/protocmp"
-	"testing"
 )
 
 func TestIntervalYearToMonthToProto(t *testing.T) {

types/interval_compound_type.go

@@ -2,6 +2,7 @@ package types
 
 import (
 	"fmt"
+
 	"github.com/substrait-io/substrait-go/proto"
 )
 

types/interval_compound_type_test.go

@@ -2,11 +2,12 @@ package types
 
 import (
 	"fmt"
+	"testing"
+
 	"github.com/google/go-cmp/cmp"
 	"github.com/stretchr/testify/assert"
 	"github.com/substrait-io/substrait-go/proto"
 	"google.golang.org/protobuf/testing/protocmp"
-	"testing"
 )
 
 func TestNewIntervalCompoundType(t *testing.T) {

types/interval_year_month_type.go

@@ -2,6 +2,7 @@ package types
 
 import (
 	"fmt"
+
 	"github.com/substrait-io/substrait-go/proto"
 )
 

types/interval_year_month_type_test.go

@@ -2,11 +2,12 @@ package types
 
 import (
 	"fmt"
+	"testing"
+
 	"github.com/google/go-cmp/cmp"
 	"github.com/stretchr/testify/assert"
 	"github.com/substrait-io/substrait-go/proto"
 	"google.golang.org/protobuf/testing/protocmp"
-	"testing"
 )
 
 func TestNewIntervalYearToMonthType(t *testing.T) {