-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add stable-2.18, fix README #681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
===========================================
+ Coverage 25.74% 76.59% +50.84%
===========================================
Files 32 20 -12
Lines 2808 2657 -151
Branches 704 679 -25
===========================================
+ Hits 723 2035 +1312
+ Misses 2044 420 -1624
- Partials 41 202 +161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the announcement from Felix Fontein the other day. But you're faster than me, we are lucky to have you @Andersson007!
I propose to remove 2.15 to gain time. Other than that, ok to merge.
Co-authored-by: Laurent Indermühle <[email protected]>
Co-authored-by: Laurent Indermühle <[email protected]>
Co-authored-by: Laurent Indermühle <[email protected]>
Co-authored-by: Laurent Indermühle <[email protected]>
@laurent-indermuehle SGTM, merged, thanks, PTAL |
@laurent-indermuehle thanks for reviewing! |
SUMMARY
CI: add stable-2.18, fix README