[PR #744/1cb9f369 backport][stable-3] fix: case when grant options is set with no other user permissions in… #750
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=80&v=4){kind=small}
#744) * fix: case when grant options is set with no other user permissions in mariadb * Create changelog fragment * fix: wrong file name ext * Update changelogs/fragments/fix_user_perms_revoke_grant_option.yml Co-authored-by: Andrew Klychkov <[email protected]> --------- Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit 1cb9f36)
|
@laurent-indermuehle as this was backported by the bot, let's merge such PRs w/o approving by another person |
Andersson007
deleted the
patchback/backports/stable-3/1cb9f369d0f8a89bd81b6b99ce07e95beeb7459c/pr-744
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #744 as merged into main (1cb9f36).
SUMMARY
fixes the edge case where we need to change permissions on a user which do not have any permissions on the database but have the grant option
Fixes #664
ISSUE TYPE
COMPONENT NAME
community.mysql_user
ADDITIONAL INFORMATION
the issue comes from the fact that when parsing the current permissions the USAGE (i.e. no permissions) is added to the privileges array then when we try to edit and the database the user has only USAGE and PRIVILEGES OPTION
like:
the revoke function first remove the PRIVILEGES OPTION with:
which remove the USAGE GRANT as well because it does not have any other purpose than holding the grant option
but then we try to remove also the USAGE GRANT with:
which is already removed and mariadb throws an error: