Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated changelogs and porting guides with notes that removed collections can still be installed manually #514

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

felixfontein
Copy link
Contributor

Updated with the changes in ansible-community/antsibull-build#647.

@mariolenz
Copy link
Collaborator

I don't see this for community.network in #514. It's not a good idea to use an officially unmaintained collection, but why not add the information that the collection can still be installed via galaxy?

I'm not saying that we should add this. It's just something that I've stumbled upon and wanted to discuss.

@felixfontein
Copy link
Contributor Author

That's because community.network has been deprecated (I kind of remember there was talk of even archiving the repository) and is not just unmaintained. While you can still install it manually, I'm not sure we should advertise that. (I used the same conditions as in the case when collections are actually removed - there we already had this sentence there, but not for renamed or deprecated collections.)

If someone wants to show it also for deprecated collections, I'd like to see a good reason for it :)

@mariolenz
Copy link
Collaborator

If someone wants to show it also for deprecated collections, I'd like to see a good reason for it :)

I don't have a good reason. Just wanted to mention it ;-)

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @felixfontein

@felixfontein felixfontein marked this pull request as ready for review January 21, 2025 16:45
@felixfontein felixfontein merged commit 8f0935a into ansible-community:main Jan 21, 2025
4 checks passed
@felixfontein felixfontein deleted the changelog branch January 21, 2025 16:46
@felixfontein
Copy link
Contributor Author

@mariolenz @oraNod @samccann thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants