-
Notifications
You must be signed in to change notification settings - Fork 606
WIP 2.19 Porting Guide stub with data tagging #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
Thanks for your Ansible docs contribution! We talk about Ansible documentation on Matrix at #docs:ansible.im if you ever want to join us and chat about the docs! We meet on Matrix every Tuesday. See the Ansible calendar for meeting details. We welcome additions to our weekly agenda items too. You can add the |
Thanks for your contribution, @nitzmahone! Please make sure that your pull request includes sufficient and meaningful details in the description. |
29f354d
to
3831694
Compare
@nitzmahone I managed to get very close with linter changes (only 10 test failures) but I spotted an unexpected exception when I call: ModuleArgsParser(sanitized_task).parse( skip_action_validation=True) With 2.18 code, my call succeeds but with this PR it raises:
My task looks like:
I am not sure how to make it pass with 2.19. |
3579eb0
to
a5ab4f9
Compare
Thanks for working on this. What's the current status with this PR? The Steering Committee would like to notify collection maintainers about this change, but it'd be nice to link to official docs instead of a draft PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text is clear and informative. I left some style nits.
@@ -5,24 +5,546 @@ | |||
Ansible-core 2.19 Porting Guide | |||
******************************* | |||
|
|||
This section discusses the behavioral changes between ``ansible-core`` 2.18 and ``ansible-core`` 2.19. | |||
This section discusses the behavioral changes between ansible-core 2.18 and ansible-core 2.19. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In https://docs.ansible.com/ansible/latest/dev_guide/style_guide/preferred_terms.html#preferred-terminology, I think either Ansible Core or ansible-core
is preferred, but @samccann can probably clarify.
Plugins that create new string instances with embedded templates must use the new ``trust_value`` function from | ||
``ansible.module_utils.datatag`` to tag those values as originating from a trusted source to allow the templates to be | ||
rendered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should trust_value()
have an example or further documentation, or are you waiting until the public API is more complete/stable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still working out where the actual docs for those things will live- none of the current options are great 😐
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Maxwell G <[email protected]>
* misc reorder, wordsmith * address review feedback
@samccann Since core 2.19.0b1 is already out there, we should probably get this one merged and published pretty soon- still an open question on the quoting of |
We're linking to this PR as temporary documentation for the pending Data Tagging changes to core.
This PR won't include any other 2.19-specific Porting Guide entries.