There is no feedback mechanism on this repo

[patricia-gallardo]

Since the only mechanism that exists is PR, I'm doing this as a PR, but please add an issues or discussion tab to this repo to handle Norway specific feedback. (I have some 😉)

[patricia-gallardo]

Ok, I'll just put it here while I remember 😅 . It's about DOFFIN_ESENDER-CONTRACT_AWARD_DEFENCE to eForms conversion (so R2.0.8). Examples are:

• 2023-310564
• 2023-310566
• 2023-338354
• 2023-620772

Bugs:

1. Wrong issue date: All <cbc:IssueDate>2023-10-12+01:00</cbc:IssueDate> are the same, error in the generated eForms is <!--WARNING: Notice Dispatch Date (BT-05) is Mandatory for all eForms subtypes, but no DATE_DISPATCH_NOTICE was found in TED XML.-->, however for these the issue date is in:

<COMPLEMENTARY_INFORMATION_CONTRACT_AWARD>
  <NOTICE_DISPATCH_DATE>
    <DAY>20</DAY>
    <MONTH>7</MONTH>
    <YEAR>2023</YEAR>
  </NOTICE_DISPATCH_DATE>
</COMPLEMENTARY_INFORMATION_CONTRACT_AWARD>

2. Wrong codelist for TYPE_OF_ACTIVITY: <TYPE_OF_ACTIVITY VALUE="..."/> are mapped to entity-activity but should probably be main-activity (possibly main-activity_authority-activity, but I still get confused by these). Examples:

• 2023-310564.xml: <TYPE_OF_ACTIVITY VALUE="GENERAL_PUBLIC_SERVICES"/> to <cbc:ActivityTypeCode listName="entity-activity">gen-pub</cbc:ActivityTypeCode>
• 2023-310566.xml: <TYPE_OF_ACTIVITY VALUE="DEFENCE"/> to <cbc:ActivityTypeCode listName="entity-activity">defence</cbc:ActivityTypeCode>
• 2023-338354.xml: <TYPE_OF_ACTIVITY VALUE="PUBLIC_ORDER_AND_SAFETY"/> to <cbc:ActivityTypeCode listName="entity-activity">pub-os</cbc:ActivityTypeCode>
• 2023-620772.xml: <TYPE_OF_ACTIVITY VALUE="ECONOMIC_AND_FINANCIAL_AFFAIRS"/> to <cbc:ActivityTypeCode listName="entity-activity">econ-aff</cbc:ActivityTypeCode>

3. Wrong lot title: More unsure about what is the right way to go here, but lets look at 2023-338354.xml which has 3 lots.
   I have chosen <AWARD_OF_CONTRACT_DEFENCE ITEM="1"><CONTRACT_TITLE> for lot title, you have chosen <OBJECT_CONTRACT_INFORMATION_CONTRACT_AWARD_NOTICE_DEFENCE><TITLE_CONTRACT>

• TITLE_CONTRACT is : "Skuddbeskyttende verneutstyr"
• CONTRACT_TITLE for ITEM="1" : Skuddbeskyttende vester
• CONTRACT_TITLE for ITEM="2" : Skuddbeskyttende hjelm
• CONTRACT_TITLE for ITEM="3" : Skuddbeskyttende skjold
  However in your eForm there is only one lot so there are more things wrong here

4. Framework Agreement not specified: Example 2023-310564.xml "Rammeavtale vektertjenester"
   <NOTICE_INVOLVES_DESC_DEFENCE VALUE="CONCLUSION_FRAMEWORK_AGREEMENT"/> should probably result in a <cbc:ContractingSystemTypeCode listName="framework-agreement">fa-wo-rc</cbc:ContractingSystemTypeCode>

[patricia-gallardo]

I do stumble over bugs here and there, so it would be helpful to have a place to submit them