feat: add multi index searching and filtering #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
7 tasks
jorgepiloto
requested changes
May 26, 2025
There was a problem hiding this comment.
Awesome work here, @Revathyvenugopal162. I left some suggestions and comments.
| @@ -147,23 +147,6 @@ Here is an example of how to add the ``static_search`` dictionary to the | |||
| }, | |||
| } | |||
| To customise the indexing of your documentation, you can use the ``index_patterns`` dictionary in the ``conf.py`` file. | |||
There was a problem hiding this comment.
This is a breaking change. We must include a deprecation warning in v1.4 about it saying v1.5 will no longer support this option. Also, v1.5 must raise an error if this option is used.
There was a problem hiding this comment.
Sure, i will add that
| if not filters: | ||
| # get the first part of the document name and sentence case it | ||
| return doc_title | ||
| for key, values in filters.items(): |
There was a problem hiding this comment.
Let's avoid this naming. All dictionaries have keys and values. Let's be more explicit with the concepts these variables are used for.
src/ansys_sphinx_theme/theme/ansys_sphinx_theme/components/ast-search-button.html
Outdated
Show resolved
Hide resolved
src/ansys_sphinx_theme/theme/ansys_sphinx_theme/components/ast-search-button.html
Show resolved
Hide resolved
src/ansys_sphinx_theme/theme/ansys_sphinx_theme/static/js/search.js
Outdated
Show resolved
Hide resolved
jorgepiloto
reviewed
May 26, 2025
src/ansys_sphinx_theme/theme/ansys_sphinx_theme/static/js/search-main.js
Show resolved
Hide resolved
jorgepiloto
requested changes
May 27, 2025
2 tasks
Co-authored-by: Jorge Martínez <[email protected]>
jorgepiloto
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advanced search features with filtering
#671 , #573