replace open_file to all the methods which requires open #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
maxcapodi78
changed the title
Samuelopez-ansys
previously approved these changes
Feb 23, 2024
Samuelopez-ansys
previously approved these changes
Feb 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4274 +/- ##
==========================================
- Coverage 81.32% 76.37% -4.95%
==========================================
Files 108 108
Lines 51643 51669 +26
==========================================
- Hits 41998 39464 -2534
- Misses 9645 12205 +2560 |
PipKat
reviewed
Feb 23, 2024
PipKat
reviewed
Feb 23, 2024
PipKat
reviewed
Feb 23, 2024
PipKat
reviewed
Feb 23, 2024
PipKat
reviewed
Feb 23, 2024
PipKat
reviewed
Feb 23, 2024
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4274 +/- ##
===========================================
+ Coverage 34.60% 81.43% +46.82%
===========================================
Files 109 109
Lines 53198 53258 +60
===========================================
+ Hits 18411 43368 +24957
+ Misses 34787 9890 -24897 |
# Conflicts: # pyaedt/generic/com_parameters.py # pyaedt/modules/PostProcessor.py
… improve_remote_file_access
for more information, see https://pre-commit.ci
… improve_remote_file_access
Co-authored-by: Kathy Pippert <[email protected]>
… improve_remote_file_access
PipKat
reviewed
Apr 4, 2024
Co-authored-by: Kathy Pippert <[email protected]>
# Conflicts: # pyaedt/modules/PostProcessor.py
…ys/pyaedt into improve_remote_file_access
Samuelopez-ansys
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open_file method checks if there is an rpc session opened and download the file from the remote machine before opening it