-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for mesh regions #4457
fix for mesh regions #4457
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
@Alberto-DM Any reason this variable was set to "not" ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4457 +/- ##
=======================================
Coverage 76.46% 76.46%
=======================================
Files 110 110
Lines 53477 53478 +1
=======================================
+ Hits 40891 40893 +2
+ Misses 12586 12585 -1 |
Is the question actually to @Alberto-DM or to me? I set it to "not" just because at the beginning the property was "automatic_settings" and not "manual_settings". Then I changed my mind during the refactoring and this is just a leftover. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #4456