Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for mesh regions #4457

Merged
merged 4 commits into from
Apr 8, 2024
Merged

fix for mesh regions #4457

merged 4 commits into from
Apr 8, 2024

Conversation

lorenzovecchietti
Copy link
Contributor

Close #4456

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Apr 3, 2024
@Samuelopez-ansys
Copy link
Member

@Alberto-DM Any reason this variable was set to "not" ?

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.46%. Comparing base (c3efa93) to head (358c8db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4457   +/-   ##
=======================================
  Coverage   76.46%   76.46%           
=======================================
  Files         110      110           
  Lines       53477    53478    +1     
=======================================
+ Hits        40891    40893    +2     
+ Misses      12586    12585    -1     

@lorenzovecchietti
Copy link
Contributor Author

@Alberto-DM Any reason this variable was set to "not" ?

Is the question actually to @Alberto-DM or to me? I set it to "not" just because at the beginning the property was "automatic_settings" and not "manual_settings". Then I changed my mind during the refactoring and this is just a leftover.

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review April 4, 2024 15:16
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) April 8, 2024 07:43
@Samuelopez-ansys Samuelopez-ansys merged commit efac98b into main Apr 8, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix_mesh_regions branch April 8, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set manual settings in mesh region
3 participants