Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Only one component per pins is created. #4469

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

MaxJPRey
Copy link
Collaborator

@MaxJPRey MaxJPRey commented Apr 8, 2024

Just renaming the method from create_components_on_pins() to create_component_on_pins() because based on the code, only one component can be created.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Apr 8, 2024
@MaxJPRey MaxJPRey requested a review from maxcapodi78 April 8, 2024 08:00
@MaxJPRey
Copy link
Collaborator Author

MaxJPRey commented Apr 8, 2024

@maxcapodi78 I don't think that those changes made in #4451 were part of the release 0.8.7. So no need to handle deprecation.

@MaxJPRey MaxJPRey changed the title Only one component per pins is created. FIX: Only one component per pins is created. Apr 8, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (4594372) to head (6951dcb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4469      +/-   ##
==========================================
+ Coverage   76.45%   81.43%   +4.97%     
==========================================
  Files         110      110              
  Lines       53479    53479              
==========================================
+ Hits        40890    43549    +2659     
+ Misses      12589     9930    -2659     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create a deprecation warning?

@MaxJPRey
Copy link
Collaborator Author

MaxJPRey commented Apr 8, 2024

Should we create a deprecation warning?

@Samuelopez-ansys I don't think so as the method was created 5 days ago and it is not part of the last release.
so no one should have ever used it.

@Samuelopez-ansys Samuelopez-ansys merged commit 62e7b43 into main Apr 8, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/create_component_on_pins branch April 8, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants