-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Only one component per pins is created. #4469
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
@maxcapodi78 I don't think that those changes made in #4451 were part of the release 0.8.7. So no need to handle deprecation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4469 +/- ##
==========================================
+ Coverage 76.45% 81.43% +4.97%
==========================================
Files 110 110
Lines 53479 53479
==========================================
+ Hits 40890 43549 +2659
+ Misses 12589 9930 -2659 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create a deprecation warning?
@Samuelopez-ansys I don't think so as the method was created 5 days ago and it is not part of the last release. |
Just renaming the method from
create_components_on_pins()
tocreate_component_on_pins()
because based on the code, only one component can be created.