Hfss argument refactoring #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete deprecated methods with more than 2 0.x. releases
# Conflicts: # pyaedt/application/Analysis.py # pyaedt/application/Analysis3DLayout.py # pyaedt/hfss.py # pyaedt/icepak.py # pyaedt/maxwell.py # pyaedt/mechanical.py # pyaedt/modules/SolveSweeps.py # pyaedt/q3d.py # pyaedt/rmxprt.py
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
gmalinve
previously requested changes
Apr 10, 2024
PipKat
reviewed
Apr 10, 2024
PipKat
reviewed
Apr 10, 2024
PipKat
reviewed
Apr 10, 2024
PipKat
reviewed
Apr 10, 2024
PipKat
reviewed
Apr 10, 2024
PipKat
reviewed
Apr 10, 2024
PipKat
reviewed
Apr 10, 2024
PipKat
reviewed
Apr 10, 2024
PipKat
reviewed
Apr 10, 2024
PipKat
reviewed
Apr 12, 2024
PipKat
reviewed
Apr 12, 2024
PipKat
reviewed
Apr 12, 2024
PipKat
reviewed
Apr 12, 2024
PipKat
reviewed
Apr 12, 2024
PipKat
reviewed
Apr 12, 2024
Co-authored-by: Kathy Pippert <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
…hfss_argument_refactoring
SMoraisAnsys
previously approved these changes
Apr 15, 2024
Co-authored-by: Devin <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
|
@SMoraisAnsys Which cases do you refer to regarding f-strings? We can replace them, but maybe could be in a different pull request. |
Probably best to wait for an official end of support for Python 2.7 (IronPython). |
|
You are right @dcrawforAtAnsys, hopefully this will happen soon 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.