Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix pdf download #4482

Merged
merged 3 commits into from
Apr 10, 2024
Merged

DOC: Fix pdf download #4482

merged 3 commits into from
Apr 10, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

Merged PR #4468 was not entirely working, this should add the extra step required to make it work.

Note: Extra changes include the removal of not used assets. They were used some months ago to build the documentation but we moved to use font awesome icons.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added maintenance Package and maintenance related documentation labels Apr 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.46%. Comparing base (7680ef4) to head (81ec412).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4482      +/-   ##
==========================================
- Coverage   81.43%   76.46%   -4.97%     
==========================================
  Files         110      110              
  Lines       53482    53482              
==========================================
- Hits        43553    40895    -2658     
- Misses       9929    12587    +2658     

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SMoraisAnsys SMoraisAnsys merged commit 9d8e94a into main Apr 10, 2024
15 checks passed
@SMoraisAnsys SMoraisAnsys deleted the doc/fix-pdf-download branch April 10, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants