Add some pyaedt emit documentation #4485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed some minor documentation issues and replaced deprecated function `instance.get_largest_problem_type()` with `instance.get_largest_emi_problem_type()`
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4485 +/- ##
==========================================
- Coverage 81.43% 76.46% -4.97%
==========================================
Files 110 110
Lines 53482 53482
==========================================
- Hits 43554 40896 -2658
- Misses 9928 12586 +2658 |
There was a problem hiding this comment.
@jsalant22 Thanks for this contribution. Since the documentation you provide does not link to other classes / modules, I feel like it should be moved to the User_guide instead of API. @Samuelopez-ansys what do you think ?
|
@jsalant22 @SMoraisAnsys You could call it EMIT Modeler, what do you think? |
move docs to user guide instead of API
Samuelopez-ansys
previously approved these changes
Apr 11, 2024
Samuelopez-ansys
approved these changes
Apr 11, 2024
myoung301
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed some minor documentation issues and replaced deprecated function
instance.get_largest_problem_type()withinstance.get_largest_emi_problem_type()