Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: improve import_nastran method #4637

Merged
merged 3 commits into from
May 6, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys self-requested a review May 6, 2024 14:06
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We this LOCs used to debug only or are they supposed to be kept ?

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) May 6, 2024 14:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 75.89%. Comparing base (1fc4252) to head (84648f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4637      +/-   ##
==========================================
- Coverage   80.83%   75.89%   -4.95%     
==========================================
  Files         119      118       -1     
  Lines       54524    54469      -55     
==========================================
- Hits        44077    41339    -2738     
- Misses      10447    13130    +2683     

@Samuelopez-ansys Samuelopez-ansys merged commit e92649e into main May 6, 2024
32 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the improve_nastran_import branch May 6, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants