Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Add thumbnails manually #4647

Closed
wants to merge 1 commit into from

Conversation

SMoraisAnsys
Copy link
Collaborator

@lorenzovecchietti This is a WIP to add thumbnails manually:

  • pros: only requires one comment in the example and it does not appear when the documentation is built
  • cons: we require this comment in the example (might not be something that we want to keep with respect to users)

Another approach could be to add an "expected" result at the beginning of the example. That way, since the expected result is plotted at first, it will be used as thumbnail.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys changed the title DOC: Add thumbnails manually DOCS: Add thumbnails manually May 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (dadf67c) to head (4abe7cd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4647      +/-   ##
==========================================
- Coverage   80.84%   80.74%   -0.11%     
==========================================
  Files         119      118       -1     
  Lines       54529    54469      -60     
==========================================
- Hits        44083    43979     -104     
- Misses      10446    10490      +44     

@SMoraisAnsys
Copy link
Collaborator Author

Closing this as changes are going to be performed in pyaedt-examples with another approach

@Samuelopez-ansys Samuelopez-ansys deleted the doc/add-example-specific-thumbnail branch August 9, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants