-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHORE: Use matplotlib Agg backend when testing #4702
Conversation
Note: For some reasons it seems that changes have been made which lead to figures showing when running CICD. This leads to tests time out as no one closes the figures manually. Here we use Agg backend which is a non-GUI backend.
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4702 +/- ##
===========================================
- Coverage 80.41% 33.88% -46.53%
===========================================
Files 121 121
Lines 55100 55100
===========================================
- Hits 44308 18671 -25637
- Misses 10792 36429 +25637 |
Since this changes might also impact the documentation, we might want to rename the environment variable a bit and see it's impact with the documentation. |
40e6e10
Changes: I removed the use of the environment variable @Samuelopez-ansys If you want, we can update the test to remove the |
@SMoraisAnsys Yes please, remove the show=False, good job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
fb0cfb7
Removing show=False proved to have impact on the tests and led me to notice "misses" in our recent refactoring. |
I'll close this PR as adding those changes increases our tests by a huge overhead. |
Multiple recent PRs struggled because figures get shown in the CICD and one would have to close them manually (which does not work through CICD). This leads to tests failing due to time out as no one closes the figures manually.
Here we use
Agg
backend which is a non-GUI backend and will avoid future PR to struggle with this issue.For example, this happened in #4626
Also related to #4672