CHORE: Fix TOML Topic #4834
Merged
CHORE: Fix TOML Topic #4834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samuelopez-ansys
requested review from
jorgepiloto,
maxcapodi78 and
SMoraisAnsys
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4834 +/- ##
==========================================
+ Coverage 82.42% 82.47% +0.04%
==========================================
Files 118 118
Lines 54388 54388
==========================================
+ Hits 44830 44856 +26
+ Misses 9558 9532 -26 |
|
Release created, and it worked. What do you think @SMoraisAnsys ? |
MaxJPRey
approved these changes
Jun 20, 2024
SMoraisAnsys
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Indeed #4812 was not enough as there were still typos left... Nice catch an thanks for the fix !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOML topic failed again with @SMoraisAnsys modifications. I have triggered again the release, I think it should work with these modifications.
https://github.com/ansys/pyaedt/actions/runs/9587855486
Once the release is created, we can merger this PR.