Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Add extensions documentation #4850

Merged
merged 6 commits into from
Jun 27, 2024
Merged

DOCS: Add extensions documentation #4850

merged 6 commits into from
Jun 27, 2024

Conversation

Samuelopez-ansys
Copy link
Member

The first version of extension documentation. We need to start implementing it because there is no information on how to use them. I have added an example for the import_nastran. But I will need your help to add the others.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (369ed4a) to head (4b6beae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4850      +/-   ##
==========================================
+ Coverage   81.93%   83.14%   +1.20%     
==========================================
  Files         118      118              
  Lines       54075    54075              
==========================================
+ Hits        44309    44962     +653     
+ Misses       9766     9113     -653     

Devin-Crawford
Devin-Crawford previously approved these changes Jun 26, 2024
Copy link
Contributor

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor suggestions, but looks good otherwise. Thanks for adding this.

@Samuelopez-ansys Samuelopez-ansys changed the title DOC: Add extensions documentation DOCS: Add extensions documentation Jun 27, 2024
Copy link
Contributor

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job

@Samuelopez-ansys Samuelopez-ansys merged commit 0d099fb into main Jun 27, 2024
46 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the doc/extensions branch June 27, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants