-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Filtersolutions #4858
FEAT: Filtersolutions #4858
Conversation
…ed, linux tests skipped.
…/pyaedt into feat/draft_filtersolutions
for more information, see https://pre-commit.ci
…/pyaedt into feat/draft_filtersolutions
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
…into FEAT_Filtersolutions
Reviewer comments are addressed and all tests are passed locally except the version comparison, pending a DLL update.
Also, the code coverage is tested locally with the following report:
|
Hi @SMoraisAnsys, I see this is pending your review. Is there anything else that needs to be changed with this PR before it's ready to approve and merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any specific reason why the tests don't run in version lower than 25R1?
In such case please add filtersolutions.py and filtersolutions_core to the exclusion list in codecov.yml file and merge.
Please make sure, in next PR to add documentation rst to generate automatically documentation for it.
@maxcapodi78 Thank you for the review. The FS API is available starting with 2025 R1 so the tests won't run unless that version or later is used. We've added the FilterSolutions-specific files and folders to the exclusion list. There is one common file that had a few lines added by this PR that doesn't pass the coverage check because the new lines aren't tested until 2025 R1. I think this is ok, but if you'd like us to add |
All comments were addressed and maxcapodi78 provided an updated review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments were addressed and maxcapodi78 approved. Approval was reset when coverage exclusion updates were pushed so re-approving now to merge.
This feature adds the Filtersolutions Python application to the PyAEDT.