Explicit server port allocation in tests #2095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2095 +/- ##
==========================================
+ Coverage 85.96% 86.58% +0.61%
==========================================
Files 90 90
Lines 10240 10240
==========================================
+ Hits 8803 8866 +63
+ Misses 1437 1374 -63 |
moe-ad
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
@PProfizi looks like the docker failure was just an instability.
https://github.com/ansys/pydpf-core/actions/runs/13407780206/job/37450854447?pr=2095
It was, but the point of the PR is to remove such instabilities, which means this does not solve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add get_next_port() function to conftest for usage in fixtures providing gRPC servers.
trying to solve #2090
Edit: looks like the error still happens when running examples on Docker