Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(arbiter-core): Environment simplification #815

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

Autoparallel
Copy link
Collaborator

Give an overview of the tasks completed
Went through and simplified the EnvironmentParameters and EnvironmentBuilder a good bit. Replaced the enums in the EnvironmentParameters with more basic EVM settings that can be used. Dropped math.rs entirely.

Link to issue(s) that this PR closes
Closes #810

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c1ae130) 55.80% compared to head (baea635) 54.97%.
Report is 1 commits behind head on main.

Files Patch % Lines
arbiter-core/src/environment/mod.rs 94.54% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   55.80%   54.97%   -0.83%     
==========================================
  Files          37       35       -2     
  Lines        7643     7472     -171     
==========================================
- Hits         4265     4108     -157     
+ Misses       3378     3364      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xJepsen 0xJepsen merged commit 3cb7fb2 into main Jan 26, 2024
11 checks passed
@0xJepsen 0xJepsen deleted the deprecate/environment-enums branch January 26, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate(arbiter-core): BlockSettings and GasSettings
2 participants