Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(arbiter-engine): agent-behavior flow #820

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

Autoparallel
Copy link
Collaborator

Give an overview of the tasks completed
This PR adds the ability for the sync() stage of a Behavior to receive the client and messager from the agent the behavior is attached to. It should then be recommended to users to make these fields optional in their behaviors at some point down the road, but we are not done with this design yet. There could be better ways to address this problem, but I'll take this for now.

Link to issue(s) that this PR closes
Closes #819

@Autoparallel Autoparallel changed the title Engine/refactor behaviors refactor(arbiter-engine): agent-behavior flow Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c1ae130) 55.80% compared to head (d31821a) 55.08%.
Report is 9 commits behind head on main.

Files Patch % Lines
arbiter-engine/src/machine.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
- Coverage   55.80%   55.08%   -0.72%     
==========================================
  Files          37       35       -2     
  Lines        7643     7488     -155     
==========================================
- Hits         4265     4125     -140     
+ Misses       3378     3363      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Autoparallel Autoparallel marked this pull request as ready for review January 30, 2024 16:17
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this seems like a clear improvement on the prior version.

@0xJepsen 0xJepsen merged commit 62769cf into main Jan 30, 2024
11 checks passed
@0xJepsen 0xJepsen deleted the engine/refactor-behaviors branch January 30, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance(arbiter-engine): Behaviors receive messager and client from above
2 participants