Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(arbiter-engine): config based simulation workflows #843

Merged
merged 18 commits into from
Feb 5, 2024

Conversation

kinrezC
Copy link
Contributor

@kinrezC kinrezC commented Feb 5, 2024

Give an overview of the tasks completed

  • Allows users the ability to control their simulation workflow via modifying a configuration toml file once the appropriate behaviors are implemented.
  • Introduces two example tests showcasing what the config driven simulations might look like. See the examples directory.
  • Introduces the arbiter-macros crate. This crate effectively replaces the deprecated arbiter-derive. Currently contains one derive procedural macro that expands an enum into composable agent behaviors. The behaviors are injected into the World::build_with_config method where they are attached to the appropriate agents.

Link to issue(s) that this PR closes
Closes #825 and #728

@kinrezC kinrezC force-pushed the feat/world-configs branch from 6bd1668 to c81dfb7 Compare February 5, 2024 19:27
@kinrezC kinrezC marked this pull request as ready for review February 5, 2024 19:27
0xJepsen
0xJepsen previously approved these changes Feb 5, 2024
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see this. Why are there duplicate behaviors in the toml?

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d0ec29a) 16.77% compared to head (cc84a07) 16.95%.
Report is 1 commits behind head on main.

❗ Current head cc84a07 differs from pull request most recent head 956216b. Consider uploading reports for the commit 956216b to get more accurate results

Files Patch % Lines
arbiter-macros/src/lib.rs 93.10% 2 Missing ⚠️
arbiter-engine/src/agent.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
+ Coverage   16.77%   16.95%   +0.18%     
==========================================
  Files          39       40       +1     
  Lines       30124    30193      +69     
==========================================
+ Hits         5053     5119      +66     
- Misses      25071    25074       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kinrezC kinrezC changed the title Simulation Configs Feat(arbiter-engine): config based simulation workflows #825 Feb 5, 2024
@kinrezC kinrezC merged commit 28f7ab3 into main Feb 5, 2024
9 checks passed
@kinrezC kinrezC deleted the feat/world-configs branch February 5, 2024 23:20
@kinrezC kinrezC changed the title Feat(arbiter-engine): config based simulation workflows #825 Feat(arbiter-engine): config based simulation workflows Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(arbiter-engine): agent configuration
3 participants