Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/core #858

Merged
merged 12 commits into from
Feb 8, 2024
Merged

Refactor/core #858

merged 12 commits into from
Feb 8, 2024

Conversation

Autoparallel
Copy link
Collaborator

@Autoparallel Autoparallel commented Feb 7, 2024

Give an overview of the tasks completed
We worked to bump to revm v4.0.0 and revm-primitives v2.0.0. This was also a large scale refactor of arbiter-core. Goal was to reduce complexity and any components that weren't really needed.

  • Consolidated error types into ArbiterCoreError enum
  • Improved error handling and succinctness
  • Renamed RevmMiddleware to ArbiterMiddleware
  • Moved src/tests/ to tests/ as this is standard
  • Removed a handful of shallow modules
  • Reorganized src/ layout
  • Consolidated and remapped imports (e.g. ethers::types::U256 as eU256 everywhere)
  • Homogenized middleware/client inputs into all ethers types. Casting into alloy/revm types only internally.
  • Probably some other random stuff

Link to issue(s) that this PR closes

@Autoparallel Autoparallel marked this pull request as ready for review February 8, 2024 01:59
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xJepsen 0xJepsen merged commit c82d56e into main Feb 8, 2024
5 of 9 checks passed
@0xJepsen 0xJepsen deleted the refactor/core branch February 8, 2024 16:03
This was referenced Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deps(revm): bump to 4.0.0 feat(arbiter-core / arbiter-engine): revert handling
2 participants