Skip to content

Commit

Permalink
why
Browse files Browse the repository at this point in the history
  • Loading branch information
anthonykim1 committed Feb 2, 2025
1 parent 78f9298 commit c6dfed7
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions src/client/common/terminal/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { useEnvExtension } from '../../envExt/api.internal';
import { ensureTerminalLegacy } from '../../envExt/api.legacy';
import { sleep } from '../utils/async';
import { isWindows } from '../utils/platform';
import { getPythonMinorVersion } from '../../repl/replUtils';
// import { getPythonMinorVersion } from '../../repl/replUtils';

@injectable()
export class TerminalService implements ITerminalService, Disposable {
Expand Down Expand Up @@ -110,14 +110,15 @@ export class TerminalService implements ITerminalService, Disposable {
const config = getConfiguration('python');
const pythonrcSetting = config.get<boolean>('terminal.shellIntegration.enabled');

const minorVersion = this.options?.resource
? await getPythonMinorVersion(
this.options.resource,
this.serviceContainer.get<IInterpreterService>(IInterpreterService),
)
: undefined;
// const minorVersion = this.options?.resource
// ? await getPythonMinorVersion(
// this.options.resource,
// this.serviceContainer.get<IInterpreterService>(IInterpreterService),
// )
// : undefined;
// || (minorVersion ?? 0) >= 13

if ((isPythonShell && !pythonrcSetting) || (isPythonShell && isWindows()) || (minorVersion ?? 0) >= 13) {
if ((isPythonShell && !pythonrcSetting) || (isPythonShell && isWindows())) {
// If user has explicitly disabled SI for Python, use sendText for inside Terminal REPL.
terminal.sendText(commandLine);
return undefined;
Expand Down

0 comments on commit c6dfed7

Please sign in to comment.