feat: shell command as bg job

[ssddOnTop]

Fixes: #2635

Pending:
Session management

[graphite-app]

Race condition: If save_process() fails on line 98, the in-memory state (lines 95-97) is already corrupted with the process added to both vectors. Subsequent operations will see the process in memory but it won't be persisted to disk, causing inconsistency. Fix by saving to disk first:

pub async fn register(...) -> Result<BackgroundProcess> {
    let process = BackgroundProcess { pid, command, cwd, log_file, started_at: Utc::now() };
    self.metadata.save_process(&process).await?;  // Disk first
    self.lock_processes()?.push(process.clone());
    self.lock_log_handles()?.push(OwnedLogFile { _handle: log_handle, pid });
    Ok(process)
}

Suggested change

	pub async fn register(
	&self,
	pid: u32,
	command: String,
	cwd: PathBuf,
	log_file: PathBuf,
	log_handle: tempfile::NamedTempFile,
	) -> Result<BackgroundProcess> {
	let process = BackgroundProcess { pid, command, cwd, log_file, started_at: Utc::now() };
	self.lock_processes()?.push(process.clone());
	self.lock_log_handles()?
	.push(OwnedLogFile { _handle: log_handle, pid });
	self.metadata.save_process(&process).await?;
	Ok(process)
	}
	pub async fn register(
	&self,
	pid: u32,
	command: String,
	cwd: PathBuf,
	log_file: PathBuf,
	log_handle: tempfile::NamedTempFile,
	) -> Result<BackgroundProcess> {
	let process = BackgroundProcess { pid, command, cwd, log_file, started_at: Utc::now() };
	self.metadata.save_process(&process).await?;
	self.lock_processes()?.push(process.clone());
	self.lock_log_handles()?
	.push(OwnedLogFile { _handle: log_handle, pid });
	Ok(process)
	}

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.