Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration settings to enable or disable resolvers #26

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

WengerK
Copy link
Member

@WengerK WengerK commented Mar 12, 2024

💬 Description

add configuration settings to enable or disable resolvers

🔢 To Review

  1. Use the new Configuration settings form on admin/config/timesup/settings
Screenshot 2024-03-12 at 16 54 42
  1. The disabled resolver should never be purged to avoid database stressing
  • Update the "Unreleased" section of the CHANGELOG.md with chan

@WengerK WengerK force-pushed the feature/settings-enable-disable-resolvers branch from 5755cd8 to 42d50bf Compare March 12, 2024 16:12
@WengerK WengerK force-pushed the feature/settings-enable-disable-resolvers branch from 42d50bf to c304662 Compare March 12, 2024 16:14
$form['resolvers']['minutely'] = [
'#type' => 'checkbox',
'#title' => $this->t('Enable Minutely resolver.'),
'#default_value' => !empty($resolvers['minutely']),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something missing here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a checkbox so true/false will check/uncheck it :) if !empty works on null and 0 value :)

@WengerK WengerK merged commit 62f9f76 into 2.0.x Apr 4, 2024
17 checks passed
@WengerK WengerK deleted the feature/settings-enable-disable-resolvers branch April 4, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants