Add support for REMOVE_BUCKET operation in group#45
Add support for REMOVE_BUCKET operation in group#45hongliangl wants to merge 2 commits intoantrea-io:mainfrom
Conversation
hongliangl
force-pushed
the
20230113-support-remove-bucket
branch
from
44b5063 to
19fcf3c
Compare
wenyingd
left a comment
wenyingd
left a comment
There was a problem hiding this comment.
Please add test code for your new logic.
|
|
||
| .idea/ | ||
| .vscode/ | ||
| vendor |
There was a problem hiding this comment.
I run command go mod vendor in this project by accident and found that this project doesn't ignore this directory.
There was a problem hiding this comment.
But no directory named as "vendor" exists in this repo.
There was a problem hiding this comment.
In Antrea, we also ignore this directory.
| } else if command == openflow15.OFPGC_REMOVE_BUCKET { | ||
| // In a request of type OFPGC_REMOVE_BUCKET, the CommandBucketId field is used to specify the identifier of the | ||
| // bucket to remove from current action bucket list. | ||
| groupMod.CommandBucketId = self.Buckets[0].BucketId |
There was a problem hiding this comment.
Does it mean a single bucket can be removed in one OFPGC_REMOVE_BUCKET request? Is it possible to remove multiple buckets in a request?
There was a problem hiding this comment.
From the document of Openflow 1.5, it cannot.
|
Please handle the golangci failure https://github.com/antrea-io/ofnet/actions/runs/3935221079/jobs/6730710061 , although it may not be introduced by your change. |
hongliangl
force-pushed
the
20230113-support-remove-bucket
branch
5 times, most recently
from
d777cbc to
49d9586
Compare
This PR also upgrades golangci-lint version to v1.50.0 and fix some fmt issues. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
force-pushed
the
20230113-support-remove-bucket
branch
from
49d9586 to
e8f71cb
Compare
Done |
Add parameter `NewGroup` to decide whether to use cache in OFSwitch when create a group. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
2 participants
Signed-off-by: Hongliang Liu lhongliang@vmware.com