Replace contiv/libovsdb with ovn-org/libovsdb#76
Open
antoninbas wants to merge 1 commit intoantrea-io:mainfrom
Open
Replace contiv/libovsdb with ovn-org/libovsdb#76antoninbas wants to merge 1 commit intoantrea-io:mainfrom
antoninbas wants to merge 1 commit intoantrea-io:mainfrom
Conversation
contiv/libovsdb is abandoned and we were using a version from 2017 Instead we use github.com/ovn-org/libovsdb, which is still under active development and is used by ovn-kubernetes. We also move the ovsdbDriver code to an internal package: it is only used for integration tests and does not need to be part of the public API. All the functions that were not used anywhere are also removed. Bump up version to v0.13.0. Fixes antrea-io#62 Signed-off-by: Antonin Bas <abas@vmware.com>
aroradaman
reviewed
Apr 1, 2024
| ovsRow := vswitchd.OpenvSwitch{ | ||
| UUID: d.rootUUID, | ||
| } | ||
| mutateOps, err := d.client.Where(&ovsRow).Mutate(&ovsRow, model.Mutation{ |
There was a problem hiding this comment.
maybe use
WhereCache(func(_ *vswitchd.OpenvSwitch) bool { return true }).Mutateinstead of matching on rootUUID, this way we don't need to maintain the rootUUID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contiv/libovsdb is abandoned and we were using a version from 2017
Instead we use github.com/ovn-org/libovsdb, which is still under active development and is used by ovn-kubernetes.
We also move the ovsdbDriver code to an internal package: it is only used for integration tests and does not need to be part of the public API. All the functions that were not used anywhere are also removed.
Bump up version to v0.13.0.
Fixes #62