Setup hello world and lint workflow #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 19, 2024 19:39
`go mod init github.com/anttharju/golangci-lint-updater`
anttiharju
force-pushed
the
setup-hello-world-and-lint-workflow
branch
from
5c382b0 to
aab1d16
Compare
added 20 commits
July 19, 2024 21:01
It exists. Using find's -exex instead of xargs seemingly fixed the issue.
This reverts commit b8b5ae0.
Matches .golangci.yml better
This is not its final form, just something to start with. Pulled from an older (currently private) project of mine.
Wanted to see the golangci-lint job fail. I think this is enough for this PR.
Caught me off-guard. Oh well.
Don't like being caught off-guard. Tighter feedback loop.
Easier for anyone using the repo to install it now.
anttiharju
added a commit
that referenced
this pull request
Oct 13, 2024
* Init Go module `go mod init github.com/anttharju/golangci-lint-updater` * Add hello world https://go.dev/play/ * Add golangci-lint workflow * Improve naming * Add .editorconfig * Read golangci-lint version from a file * Remove unnecessary names * Add a makefile target for installing the linter * Rename workflow to be more generic * Add make shellcheck and workflow step * Fix shellcheck issues * Separate shellcheck from golangci-lint job * Debug shellcheck * Remove which shellcheck It exists. Using find's -exex instead of xargs seemingly fixed the issue. * See if shellcheck catches issues in the action run * Revert "See if shellcheck catches issues in the action run" This reverts commit b8b5ae0. * Rename .golangci-version to .golangci.version Matches .golangci.yml better * Add make lint target See https://tech.davis-hansson.com/p/make/ * Add lint-fix target and rename install-linter to lint-install * Add golangci-lint config file This is not its final form, just something to start with. Pulled from an older (currently private) project of mine. * Remove forbidigo Wanted to see the golangci-lint job fail. I think this is enough for this PR. * Satisfy gosmopolitan Caught me off-guard. Oh well. * Add make ci for use with a pre-commit hook Don't like being caught off-guard. Tighter feedback loop. * Add make install-pre-commit-hook Easier for anyone using the repo to install it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up some infra before actually developing anything.