-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add chart bar/pie/donut #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aarebecca
commented
Dec 9, 2025
- 新增条形图、饼图、甜甜圈图
- 优化现有设计
- 更新 Gallery 列表
Summary of ChangesHello @Aarebecca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求为信息图库引入了全新的图表类型,包括条形图、饼图和甜甜圈图,显著增强了数据可视化能力。同时,它还对现有的设计组件进行了精细优化,并对画廊模板的管理方式进行了重构,以提高代码质量和未来的可扩展性。这些改进共同提升了信息图的视觉效果和用户体验。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 30.57% 29.92% -0.66%
==========================================
Files 293 297 +4
Lines 19566 20527 +961
Branches 1013 1014 +1
==========================================
+ Hits 5983 6142 +159
- Misses 13580 14382 +802
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 新增了条形图、饼图和甜甜圈图,并对现有的设计和 Gallery 列表进行了优化和更新,整体质量非常高。新增加的图表组件代码结构清晰,考虑周全,对各种配置和边界情况都做了处理。尤其是在 site/src/components/Gallery/templates.ts 文件中的重构,通过提取公共配置和使用 Map 等方式,极大地提升了代码的可读性、可维护性和性能,是非常出色的实践。我只发现一个可以改进的小问题,在 chart-line.tsx 中关于唯一 ID 生成方式的建议,以增强代码的确定性和可测试性。总体来说,这是一次非常棒的更新!
|
加到 /ai 下了不? |
加上了 |