Skip to content

Conversation

@Alexzjt
Copy link
Contributor

@Alexzjt Alexzjt commented Nov 26, 2025

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

修正package.json中的dependencies

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions
Copy link
Contributor

你好 @Alexzjt,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

@github-actions github-actions bot added the pr(chore) configuration changes label Nov 26, 2025
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Nov 26, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Alexzjt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此 PR 主要进行依赖项的维护工作,旨在修正 s2-react-componentss2-react 两个包的依赖配置。通过调整生产依赖和对等依赖,确保了项目在不同环境下的稳定运行和正确的包解析,避免了潜在的依赖问题。

Highlights

  • 依赖调整: 在 packages/s2-react-components/package.json 中,将 react-colordevDependencies 移至 dependencies,并新增 lesspeerDependencies
  • 对等依赖更新: 在 packages/s2-react/package.json 中,新增 @antv/g2lesspeerDependencies
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

你好, @Alexzjt CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @Alexzjt CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added 🚨 test failed 单元测试挂了 🚨 lint failed 静态检查失败 labels Nov 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,这次 PR 主要修改了 s2-react-componentss2-react 的依赖配置。

s2-react-components 中,将 react-colordevDependencies 移到了 dependencies。这是一个正确的方向,但对于组件库来说,更好的做法是将其声明为 peerDependencies,以避免在宿主应用中造成版本冲突或重复打包。我已经提出了具体的修改建议。同时,将 less 添加到 peerDependencies 是正确的。

s2-react 中,将 @antv/g2less 添加到 peerDependencies 是合理的,因为图表功能和样式文件需要宿主环境提供这些依赖。

总体来说,这些改动有助于更清晰地管理依赖关系。请考虑我对 react-color 的建议。

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Nov 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.66%. Comparing base (ecdc9c8) to head (0f346d8).
⚠️ Report is 725 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3246      +/-   ##
==========================================
+ Coverage   75.77%   79.66%   +3.89%     
==========================================
  Files         257      217      -40     
  Lines       11994    11988       -6     
  Branches     2464     2689     +225     
==========================================
+ Hits         9088     9550     +462     
+ Misses       1398      811     -587     
- Partials     1508     1627     +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the 🚨 lint failed 静态检查失败 label Nov 26, 2025
@github-actions
Copy link
Contributor

Size Change: +2 B (0%)

Total Size: 628 kB

Filename Size Change
./packages/s2-core/dist/s2.min.css 583 B +2 B (+0.34%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 158 kB
./packages/s2-core/dist/s2.min.js 263 kB
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.3 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 1.59 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@Alexzjt Alexzjt merged commit 2352ddf into next Nov 27, 2025
9 checks passed
@Alexzjt Alexzjt deleted the chore/dep1121 branch November 27, 2025 06:29
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-react-v2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next 2.0-next 版本的问题 pr(chore) configuration changes released on @latest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants