-
Notifications
You must be signed in to change notification settings - Fork 220
chore: 修正dep #3246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 修正dep #3246
Conversation
|
你好 @Alexzjt,非常感谢你的贡献. Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
Summary of ChangesHello @Alexzjt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此 PR 主要进行依赖项的维护工作,旨在修正 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
你好,这次 PR 主要修改了 s2-react-components 和 s2-react 的依赖配置。
在 s2-react-components 中,将 react-color 从 devDependencies 移到了 dependencies。这是一个正确的方向,但对于组件库来说,更好的做法是将其声明为 peerDependencies,以避免在宿主应用中造成版本冲突或重复打包。我已经提出了具体的修改建议。同时,将 less 添加到 peerDependencies 是正确的。
在 s2-react 中,将 @antv/g2 和 less 添加到 peerDependencies 是合理的,因为图表功能和样式文件需要宿主环境提供这些依赖。
总体来说,这些改动有助于更清晰地管理依赖关系。请考虑我对 react-color 的建议。
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3246 +/- ##
==========================================
+ Coverage 75.77% 79.66% +3.89%
==========================================
Files 257 217 -40
Lines 11994 11988 -6
Branches 2464 2689 +225
==========================================
+ Hits 9088 9550 +462
+ Misses 1398 811 -587
- Partials 1508 1627 +119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: +2 B (0%) Total Size: 628 kB
ℹ️ View Unchanged
|
|
🎉 This PR is included in version @antv/s2-react-v2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
修正package.json中的dependencies
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge