-
Notifications
You must be signed in to change notification settings - Fork 220
docs: 去掉过时配置 #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 去掉过时配置 #3260
Conversation
|
你好 @Alexzjt,非常感谢你的贡献. Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
Summary of ChangesHello @Alexzjt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 本次拉取请求主要聚焦于文档的维护和清理工作,移除了大量过时的配置项和文档标记。核心改动是废弃了 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3260 +/- ##
==========================================
+ Coverage 75.77% 79.62% +3.85%
==========================================
Files 257 217 -40
Lines 11994 12006 +12
Branches 2464 2692 +228
==========================================
+ Hits 9088 9560 +472
+ Misses 1398 817 -581
- Partials 1508 1629 +121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: 0 B Total Size: 628 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 主要移除了文档和示例中已过时的 supportsCSSTransform 配置,以及一些元数据标签(如 tag: New 和 new: true),使文档内容保持最新。整体修改是正确的,并且在多处文件中保持了一致性。
另外,我注意到在 s2-site/docs/manual/migration-v2.zh.md 文件中,您移除了示例代码中的 renderer.setConfig({ enableDirtyCheck: true })。然而,在对应的英文文档 s2-site/docs/manual/migration-v2.en.md 中,这行代码依然存在。为了保持中英文文档的一致性,建议在英文文档中也移除这行代码。由于这部分内容不在本次 PR 的 diff 中,我无法直接评论,请您在后续修改中关注。
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge