Skip to content

Conversation

@Alexzjt
Copy link
Contributor

@Alexzjt Alexzjt commented Dec 19, 2025

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added the pr(documentation) documentation label Dec 19, 2025
@github-actions
Copy link
Contributor

你好 @Alexzjt,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Dec 19, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Alexzjt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

本次拉取请求主要聚焦于文档的维护和清理工作,移除了大量过时的配置项和文档标记。核心改动是废弃了 supportsCSSTransform 属性,并相应更新了 API 文档、迁移指南和常见问题解答,以确保用户获取到最新且准确的配置信息。此外,还简化了部分 G 渲染器的配置示例,并清除了示例元数据中不再需要的“新”标签。

Highlights

  • 文档元数据清理: 移除了大量文档文件中过时的 tag: Newtag: Updated 标记,使文档元数据保持最新和简洁。
  • 废弃 supportsCSSTransform 配置: 从 S2Options 配置中移除了 supportsCSSTransform 属性及其相关说明,并在迁移指南和常见问题解答中明确了其已废弃的状态。
  • G 渲染器配置简化: 简化了 transformCanvasConfig 中的配置,移除了对 enableCullingenableDirtyCheck 的显式设置,以及 supportsCSSTransform 的配置,以反映最新的 G 渲染器使用方式。
  • FAQ 内容更新: 删除了常见问题解答 (FAQ) 中关于 transform: scale 导致鼠标坐标响应不正确问题的解决方案,因为相关的 supportsCSSTransform 属性已被移除。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.62%. Comparing base (ecdc9c8) to head (1d465bb).
⚠️ Report is 733 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3260      +/-   ##
==========================================
+ Coverage   75.77%   79.62%   +3.85%     
==========================================
  Files         257      217      -40     
  Lines       11994    12006      +12     
  Branches     2464     2692     +228     
==========================================
+ Hits         9088     9560     +472     
+ Misses       1398      817     -581     
- Partials     1508     1629     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Size Change: 0 B

Total Size: 628 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 158 kB
./packages/s2-core/dist/s2.min.css 583 B
./packages/s2-core/dist/s2.min.js 263 kB
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.3 kB
./packages/s2-react/dist/s2-react.min.js 38.5 kB
./packages/s2-vue/dist/s2-vue.min.css 1.59 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 主要移除了文档和示例中已过时的 supportsCSSTransform 配置,以及一些元数据标签(如 tag: Newnew: true),使文档内容保持最新。整体修改是正确的,并且在多处文件中保持了一致性。

另外,我注意到在 s2-site/docs/manual/migration-v2.zh.md 文件中,您移除了示例代码中的 renderer.setConfig({ enableDirtyCheck: true })。然而,在对应的英文文档 s2-site/docs/manual/migration-v2.en.md 中,这行代码依然存在。为了保持中英文文档的一致性,建议在英文文档中也移除这行代码。由于这部分内容不在本次 PR 的 diff 中,我无法直接评论,请您在后续修改中关注。

@github-actions
Copy link
Contributor

你好, @Alexzjt CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @Alexzjt CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added 🚨 test failed 单元测试挂了 and removed 🚨 test failed 单元测试挂了 labels Dec 19, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Alexzjt Alexzjt merged commit 807016c into next Dec 23, 2025
9 checks passed
@Alexzjt Alexzjt deleted the docs/1219 branch December 23, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next 2.0-next 版本的问题 pr(documentation) documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants