-
Notifications
You must be signed in to change notification settings - Fork 220
fix: 复用单元格滚动后TableSheet的seriesNumber和普通单元格样式异常 #3272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
你好 @Alexzjt,非常感谢你的贡献. Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
Summary of ChangesHello @Alexzjt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求主要修复了 TableSheet 在单元格复用滚动后,系列号单元格及其他普通单元格样式可能出现异常的缺陷。核心改动在于重构了系列号单元格的文本样式获取逻辑,将其上移至基类 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
这个 PR 修复了 TableSheet 在滚动和单元格复用后,序号单元格和普通单元格样式异常的问题。核心改动是将序号单元格的样式逻辑从 TableSeriesNumberCell 移至其父类 TableDataCell 中,通过判断 meta.valueField 来应用正确的样式。这个方法很巧妙地解决了单元格复用时,由于 TableDataCell 实例被复用于渲染序号列而导致样式不正确的问题。此外,PR 还修复了一个文档中的链接问题。整体来看,代码改动清晰、合理。我只发现一个可以改进的小地方,以增强代码的健壮性。
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3272 +/- ##
==========================================
+ Coverage 75.77% 79.13% +3.36%
==========================================
Files 257 222 -35
Lines 11994 12185 +191
Branches 2464 2737 +273
==========================================
+ Hits 9088 9643 +555
+ Misses 1398 887 -511
- Partials 1508 1655 +147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: +17 B (0%) Total Size: 720 kB
ℹ️ View Unchanged
|
|
🎉 This PR is included in version @antv/s2-v2.4.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge