removes the vector allocation in shred::merkle::make_merkle_proof #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
make-merkle-proof-no-alloc
branch
from
2d45ebf to
1d1c4f4
Compare
The commit returns an iterator from shred::merkle::make_merkle_proof. This iterator is then directly written to shred payload.
behzadnouri
force-pushed
the
make-merkle-proof-no-alloc
branch
from
1d1c4f4 to
ac4b372
Compare
AshwinSekar
approved these changes
Jan 17, 2025
| let entry = &node.as_ref()[..SIZE_OF_MERKLE_PROOF_ENTRY]; | ||
| let entry = <&MerkleProofEntry>::try_from(entry).unwrap(); | ||
| Some(Ok(entry)) | ||
| } else if offset + 1 == tree.len() { |
There was a problem hiding this comment.
Looks correct, based on get_merkle_tree_size when size reaches 1, the offset will always fulfill this condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
shred::merkle::make_merkle_proofunnecessarily allocates a vector.Summary of Changes
The commit returns an iterator from
shred::merkle::make_merkle_proof. This iterator is then directly written to shred payload.