Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract vote-interface crate #4482

Merged
merged 8 commits into from
Jan 19, 2025

Conversation

kevinheavey
Copy link

Problem

solana_program::vote imposes a solana_program dep in a few places

Summary of Changes

  • Move to its own crate and re-export for backwards compatibility
  • Make serde and bincode optional in the new crate
  • Remove thiserror and replace with inline impl

Copy link

mergify bot commented Jan 15, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@kevinheavey kevinheavey force-pushed the extract-vote-interface branch from 7f05824 to dfed76d Compare January 16, 2025 00:51
@kevinheavey kevinheavey requested a review from joncinque January 16, 2025 10:47
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really cool to see this all come together! @yihau can you accept ownership of solana-vote-interface?

@@ -1,8 +1,22 @@
use super::{vote_state_0_23_5::VoteState0_23_5, vote_state_1_14_11::VoteState1_14_11, *};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting rid of the globs 🙏

@kevinheavey kevinheavey force-pushed the extract-vote-interface branch from dfed76d to 5a96bd2 Compare January 18, 2025 22:24
@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Jan 19, 2025
@mergify mergify bot merged commit 46b1f9a into anza-xyz:master Jan 19, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants