Fix clippy lint in programs/sbf
#4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cargo clippy nightly 2024-11-22 requires that large constant arrays be declared as static.
Summary of Changes
I followed clippy's suggestion to make the array static. In the test, we only use its zeroed values to ensure the stack and heap are initialized as zero in an
assert_eq!macro.According to clippy's documentation, const arrays are inlined, while static are initialized in a fixed memory location to which every usage refers. As we are only using it for a comparison, either constant or static should do the job.