Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes QUIC port offsetting and checks in LegacyContactInfo #4507

Merged

Conversation

behzadnouri
Copy link

Problem

With the new ContactInfo we no longer need QUIC_PORT_OFFSET.
Working towards removing QUIC_PORT_OFFSET, this commit removes QUIC port offsetting and checks in LegacyContactInfo.

Summary of Changes

The commit removes QUIC port offsetting and checks in LegacyContactInfo.

@behzadnouri behzadnouri force-pushed the rm-legacy-contact-info-quic-ports branch from b762d65 to 00719ce Compare January 16, 2025 22:43
With the new ContactInfo we no longer need QUIC_PORT_OFFSET.
Working towards removing QUIC_PORT_OFFSET, this commit removes QUIC port
offsetting and checks in LegacyContactInfo.
@behzadnouri behzadnouri force-pushed the rm-legacy-contact-info-quic-ports branch from 00719ce to b035577 Compare January 17, 2025 13:55
Copy link

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming further commits follow up to clean up the rest of the reference to QUIC_PORT_OFFSET)

@behzadnouri behzadnouri merged commit bf09fd5 into anza-xyz:master Jan 17, 2025
47 checks passed
@behzadnouri behzadnouri deleted the rm-legacy-contact-info-quic-ports branch January 17, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants