Repair metrics #4511
Merged
Repair metrics #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bw-solana
force-pushed
the
repair_metrics
branch
from
49fe722 to
7b96b48
Compare
bw-solana
commented
Jan 17, 2025
| ("get-votes-elapsed", self.get_votes_elapsed, i64), | ||
| ("add-votes-elapsed", self.add_votes_elapsed, i64), | ||
| ( | ||
| "purge-outstanding-repairs", |
There was a problem hiding this comment.
this is 1 of 2 new metrics added. Everything else should just be cosmetic change
bw-solana
commented
Jan 17, 2025
| i64 | ||
| ), | ||
| ( | ||
| "handle-popular-pruned-forks", |
There was a problem hiding this comment.
this is the 2nd metric changed
bw-solana
commented
Jan 17, 2025
|
|
||
| impl RepairMetrics { | ||
| pub fn maybe_report(&mut self) { | ||
| if self.last_report.elapsed().as_secs() > 2 { |
There was a problem hiding this comment.
I don't like this style since it's easy to think we report every 2 seconds but it's actually 3... but decided to not change it with this PR
bw-solana
force-pushed
the
repair_metrics
branch
from
924bfbb to
fa8ed8d
Compare
bw-solana
force-pushed
the
repair_metrics
branch
from
fa8ed8d to
420dbd4
Compare
|
@alessandrod & @AshwinSekar - I'll give it another couple of days in case you want to review (or request more time). Else, I'll merge this in with Alex's approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fn RepairService::runis giant and unwieldy. Shrinking this down a bit would help with parsing more quickly.There are also multiple metrics structs intertwined together, and some missing timing metrics.
Trying to unspaghettify™️ part of this code
Summary of Changes
RepairMetricsstruct to wrap existing metrics