Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows clippy #4526

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix windows clippy #4526

merged 1 commit into from
Jan 17, 2025

Conversation

bw-solana
Copy link

@bw-solana bw-solana commented Jan 17, 2025

Problem

Seeing CI failures:

error: manually constructing a nul-terminated string
   --> install\src\command.rs:427:17
    |
427 |                 "Environment\0".as_ptr() as LPARAM,
    |                 ^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Environment"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals
    = note: `-D clippy::manual-c-str-literals` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_c_str_literals)]`

error: could not compile `agave-install` (lib) due to 1 previous error

Summary of Changes

Switch to using c literal

@bw-solana bw-solana marked this pull request as ready for review January 17, 2025 20:35
@bw-solana bw-solana merged commit 9ea581a into anza-xyz:master Jan 17, 2025
42 of 44 checks passed
@bw-solana bw-solana deleted the windows_clippy branch January 17, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants