Buffer pre-session tasks in BP unified scheduler #4949
Merged
+653
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
reviewed
Feb 12, 2025
runtime/src/bank_forks.rs
Outdated
| // Skip registering for block production. Both the replay stage and PohRecorder | ||
| // don't support _concurrent block production_ at all. It's strongly assumed that | ||
| // block is produced in singleton way and it's actually desired, while ignoring the | ||
| // opportunity cost of (hopefully rare!) fork switching... |
There was a problem hiding this comment.
@steviez do we have data on how often we switch forks during leader slot? I'm not aware of any, but I don't believe it's super uncommon for it to happen?
There was a problem hiding this comment.
I don't think we have any data on hand OR any metrics to easily measure this unfortunately
apfitzge
reviewed
Feb 12, 2025
apfitzge
reviewed
Feb 12, 2025
apfitzge
reviewed
Feb 12, 2025
| (true, true) | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
I can't get to the line in review.
There's a series of comments on line 1332:
// High-level flow of new tasks:
// 1. the replay stage thread send a new task.
// 2. the scheduler thread accepts the task.
// 3. the scheduler thread dispatches the task after proper locking.
// 4. the handler thread processes the dispatched task.
// 5. the handler thread reply back to the scheduler thread as an executed task.
// 6. the scheduler thread post-processes the executed task.we should update this comment imo, but it doesn't necessarily have to be part of this PR - maybe not until the full implementation of production w/ all verification is in.
There was a problem hiding this comment.
yeah, I'll update them later at once.
apfitzge
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While #4533 introduced (really!) minimal integration between banking stage and unified scheduler, the unified scheduler still needs several improvements for optimal block production.
Summary of Changes
As a first step, support pre-session buffering.
extracted from #3946 (well, with large code cleaning up!)