v2.2: rolls out chained Merkle shreds to 100% of mainnet slots (backport of #5088) #5098
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 2f2dbd1)
| ClusterType::Development => true, | ||
| ClusterType::Devnet => true, | ||
| // Roll out chained Merkle shreds to ~53% of mainnet slots. | ||
| ClusterType::MainnetBeta => slot % 19 < 10, |
There was a problem hiding this comment.
for the backports, can we simply set this to true? removal fine to ride master
There was a problem hiding this comment.
I don't see the point of keeping unused code around.
In particular, keeping more discrepancy between branches would introduce more risk if more changes are backported and they hit merge conflicts or something is missed out because the branches are different.
There was a problem hiding this comment.
i don't see the point of taking extra changes to stable
There was a problem hiding this comment.
avoiding unnecessary discrepancy between branches:
In particular, keeping more discrepancy between branches would introduce more risk if more changes are backported and they hit merge conflicts or something is missed out because the branches are different.
There was a problem hiding this comment.
we don't backport feature gate removals. this is the same class of change
There was a problem hiding this comment.
Backporting a feature gate removal will break ledger tool for slots across epoch-boundary that the feature was activated. And a feature gate removal does not need to be backported anyways. But we need to backport this change; so not sure how it makes them in the same class.
And I think keeping the backported change the same as the master branch is a better approach for the reasons mentioned earlier above. Unnecessarily causing them to digress is only asking for problems.
Problem
Incrementally rolling out chained Merkle shreds to mainnet.
Summary of Changes
The commit rolls out chained Merkle shreds to 100% of mainnet slots.
This is an automatic backport of pull request #5088 done by Mergify.