fix typo in function #5108
Open
fix typo in function #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpyattaev
reviewed
Mar 2, 2025
| @@ -141,7 +141,7 @@ pub mod tests { | |||
| }; | |||
|
|
|||
| impl AccountsDb { | |||
| pub fn set_geyser_plugin_notifer(&mut self, notifier: Option<AccountsUpdateNotifier>) { | |||
| pub fn set_geyser_plugin_notifier(&mut self, notifier: Option<AccountsUpdateNotifier>) { | |||
There was a problem hiding this comment.
can not change public API without a version bump
There was a problem hiding this comment.
Correct. However, we can do the following:
- Add a new method without the spelling mistake (
set_geyser_plugin_notifier) - Update the old method
set_geyser_plugin_notiferto simply call the new methodset_geyser_plugin_notifier - Add a deprecation warning to the old method, including mention that the function has been deprecated in v2.3
We can then rip out the function with incorrect spelling at a later date once we are shipping a sufficiently new version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accounts-db/src/accounts_db/geyser_plugin_utils.rs
set_geyser_plugin_notifer - set_geyser_plugin_notifier
account-decoder/src/parse_token.rs
id as a known - id is a known