v2.2: If the account length is zero, no data region is present (backport of #5122) #5136
+35
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
The Firedancer team maintains a line-for-line reimplementation of the |
This only affects unaligned programs, as for aligned programs the resize area address will match the account region address if the data length is zero. (cherry picked from commit 561023d)
seanyoung
force-pushed
the
mergify/bp/v2.2/pr-5122
branch
from
c298965 to
475324f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affects unaligned programs, as for aligned programs the resize area address will match the account region address if the data length is zero.
Problem
When an account is length zero, then there is no account data region. Memcpy's across the data should be permitted since there is no data region.
Found by @topointon-jump
Summary of Changes
Fixes #
This is an automatic backport of pull request #5122 done by [Mergify](https://mergify.com).