Update dashmap to 6.1.0 for cache-aligned shards #5144
+227
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
reviewed
Mar 5, 2025
There was a problem hiding this comment.
I don't know how to measure the impact of the changes, running the accounts-db benches locally gives me wild results on main
For dependency version bumps, I don't think we have required benches / data to show that the bump improves thing. But, if we suspect that this PR will have a meaningful impact, it could be cool to measure to see.
Brooks or Haoran might be able to lend some insight on the benches and/or whatever else to look into to evaluate any perf improvements
Comment on lines
-371
to
+372
| for (key, entry) in shard.iter().choose_multiple(rng, remaining_samples) { | ||
| for (key, entry) in unsafe { shard.iter().map(|bucket| bucket.as_ref()) } | ||
| .choose_multiple(rng, remaining_samples) |
There was a problem hiding this comment.
The code change is fairly small, but in general, probably good to alert someone from AccountsDb team for review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DashMap is still used in many places notably Solana accounts-db
There is a new version with some changes which should provide some speedup as presented in the benchmark of this PR
xacrimon/dashmap#303
Summary of Changes
Update to dashmap 6.1.0
Note:
serial_testandgovernorso there isn't a need for 5.5.3 anymoreFixes #