make is_nonoverlapping private and remove num-traits dep from program-memory #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
changed the title
|
We could also add the missing |
Where? |
|
Oh guessing you mean these ones: Let's leave those for another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is only used here and in solana-bpf-loader program. When used here, it doesn't need num-traits. I have opened a PR in the Agave repo to copy the num-traits version into solana-bpf-loader program anza-xyz/agave#4888
The num-traits dep is causing pinocchio to copy-paste a significant amount of code.
Since the function is hidden this is not a breaking change.