Refactor redirect_stderr_to_file to solana-logger #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, this code was stuck in validator crate but can be useful to every CLI tool that uses solana_logger crate. |
joncinque
reviewed
Mar 4, 2025
logger/Cargo.toml
Outdated
| @@ -2,7 +2,7 @@ | |||
| name = "solana-logger" | |||
| description = "Solana Logger" | |||
| documentation = "https://docs.rs/solana-logger" | |||
| version = "2.2.1" | |||
| version = "2.2.2" | |||
There was a problem hiding this comment.
You shouldn't do the version bump here, the release job will take care of that automatically as mentioned at https://github.com/anza-xyz/solana-sdk?tab=readme-ov-file#publishing-a-crate-from-this-repository
logger/src/lib.rs
Outdated
Comment on lines
83
to
84
| #[cfg(unix)] | ||
| #[cfg(not(target_arch = "wasm32"))] |
There was a problem hiding this comment.
nit: these can get condensed into one
Suggested change
| #[cfg(unix)] | |
| #[cfg(not(target_arch = "wasm32"))] | |
| #[cfg(all(unix, not(target_arch = "wasm32")))] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redirect_stderr_to_file can be used multiple applications. I found the need to use it in vortexor. Moving this from validator to solana-logger.
Refactored from https://github.com/anza-xyz/agave/blob/master/validator/src/lib.rs#L39 which will be removed once this change made to the SDK