Skip to content

Commit

Permalink
chore(dev/benchmarks): Add 0.5.0 release to benchmark run + enable bu…
Browse files Browse the repository at this point in the history
…ild with against refacotred CMake (#516)

After #511 there is a slightly different way to build the nanoarrow with
IPC support (required by benchmarks).
  • Loading branch information
paleolimbot authored Jun 11, 2024
1 parent 784325b commit 8680f6d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
10 changes: 5 additions & 5 deletions dev/benchmarks/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@ fetchcontent_declare(benchmark
fetchcontent_makeavailable(benchmark)

if(IS_DIRECTORY "${NANOARROW_BENCHMARK_SOURCE_URL}")
# In nanoarrow >= 0.6.0, optional features use NANOARROW_XXX=ON instead
# of being packaged as separate projects.
set(NANOARROW_IPC
ON
CACHE INTERNAL "")
fetchcontent_declare(nanoarrow SOURCE_DIR "${NANOARROW_BENCHMARK_SOURCE_URL}")
fetchcontent_declare(nanoarrow_ipc
SOURCE_DIR
"${NANOARROW_BENCHMARK_SOURCE_URL}/extensions/nanoarrow_ipc")

fetchcontent_makeavailable(nanoarrow)
fetchcontent_makeavailable(nanoarrow_ipc)
elseif(NOT "${NANOARROW_BENCHMARK_SOURCE_URL}" STREQUAL "")
fetchcontent_declare(nanoarrow URL "${NANOARROW_BENCHMARK_SOURCE_URL}")
fetchcontent_declare(nanoarrow_ipc URL "${NANOARROW_BENCHMARK_SOURCE_URL}"
Expand Down
11 changes: 11 additions & 0 deletions dev/benchmarks/CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@
"NANOARROW_BENCHMARK_SOURCE_URL": "${sourceDir}/../.."
}
},
{
"name": "v0.5.0",
"displayName": "v0.5.0",
"description": "Uses the nanoarrow C sources the 0.5.0 release.",
"inherits": [
"base"
],
"cacheVariables": {
"NANOARROW_BENCHMARK_SOURCE_URL": "https://github.com/apache/arrow-nanoarrow/archive/refs/tags/apache-arrow-nanoarrow-0.5.0.zip"
}
},
{
"name": "v0.4.0",
"displayName": "v0.4.0",
Expand Down

0 comments on commit 8680f6d

Please sign in to comment.