bounds fix

apache · Jan 7, 2025 · a15931f · a15931f
1 parent 09500de
commit a15931f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/nanoarrow/hpp/view.hpp b/src/nanoarrow/hpp/view.hpp
@@ -80,7 +80,7 @@ struct RandomAccessRange {
   };
 
   const_iterator begin() const { return {offset, this}; }
-  const_iterator end() const { return {size, this}; }
+  const_iterator end() const { return {offset + size, this}; }
 };
 
 template <typename Next>

diff --git a/src/nanoarrow/hpp/view_test.cc b/src/nanoarrow/hpp/view_test.cc
@@ -150,6 +150,7 @@ TEST(NanoarrowHppTest, NanoarrowHppViewArrayOffsetTest) {
   ASSERT_EQ(ArrowArrayAppendInt(array.get(), 3), NANOARROW_OK);
   ASSERT_EQ(ArrowArrayFinishBuildingDefault(array.get(), nullptr), NANOARROW_OK);
   array->offset = 2;
+  array->length = 2;
 
   EXPECT_THAT(nanoarrow::ViewArrayAs<int32_t>(array.get()), testing::ElementsAre(2, 3));
 
@@ -178,6 +179,7 @@ TEST(NanoarrowHppTest, NanoarrowHppViewArrayAsBytesOffsetTest) {
   ASSERT_EQ(ArrowArrayAppendString(array.get(), "qux"_asv), NANOARROW_OK);
   ASSERT_EQ(ArrowArrayFinishBuildingDefault(array.get(), nullptr), NANOARROW_OK);
   array->offset = 2;
+  array->length = 2;
 
   EXPECT_THAT(nanoarrow::ViewArrayAsBytes<32>(array.get()),
               testing::ElementsAre("baz"_asv, "qux"_asv));
@@ -209,6 +211,7 @@ TEST(NanoarrowHppTest, NanoarrowHppViewArrayAsFixedSizeBytesOffsetTest) {
   ASSERT_EQ(ArrowArrayAppendBytes(array.get(), {{"qux"}, FixedSize}), NANOARROW_OK);
   ASSERT_EQ(ArrowArrayFinishBuildingDefault(array.get(), nullptr), NANOARROW_OK);
   array->offset = 2;
+  array->length = 2;
 
   EXPECT_THAT(nanoarrow::ViewArrayAsFixedSizeBytes(array.get(), FixedSize),
               testing::ElementsAre("baz"_asv, "qux"_asv));